OTA-260: add duplicate manifest error check#1120
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Jul 2, 2021
Merged
OTA-260: add duplicate manifest error check#1120openshift-merge-robot merged 1 commit intoopenshift:masterfrom
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
openshift-ci
Bot
added
approved
jottofar
force-pushed
the
ota-260-manifest-check
branch
from
0222a24 to
d256246
Compare
wking
reviewed
Jun 23, 2021
wking
reviewed
Jun 23, 2021
wking
reviewed
Jun 23, 2021
wking
reviewed
Jun 23, 2021
wking
reviewed
Jun 23, 2021
wking
reviewed
Jun 23, 2021
wking
reviewed
Jun 23, 2021
wking
reviewed
Jun 23, 2021
wking
reviewed
Jun 23, 2021
jottofar
force-pushed
the
ota-260-manifest-check
branch
3 times, most recently
from
65b16ab to
fdc8b02
Compare
openshift-ci
Bot
added
the
approved
wking
reviewed
Jul 2, 2021
wking
reviewed
Jul 2, 2021
wking
reviewed
Jul 2, 2021
jottofar
force-pushed
the
ota-260-manifest-check
branch
from
fdc8b02 to
4fdc09d
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jottofar, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure each manifest contains the Kubernetes required fields apiVersion, kind, and metadata.name. Use those fields along with the optional field metadata.namespace to uniquely identify each manifest. Generate an error for any duplicate manifests, i.e. any with the same unique id.
Version is removed from apiVersion to produce Group which is what is actually used to form the above mentioned unique id. Some resources, e.g. ConfigMap, have an apiVersion with only a version identifier, e.g.
v1. In these cases the Group is set to""as opposed tov1.See OTA-260.